Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:w write in background #4013

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Conversation

stevenguh
Copy link
Contributor

This changes the :w behavior to write in background to unfreeze the VS Code UI when the user is using VS Code Remote while allowing operation like wq and wa to work in VS Code

What this PR does / why we need it:
This fix the regression caused by #3998

Which issue(s) this PR fixes
#3998
#3922
#3777

@stevenguh stevenguh force-pushed the feature/fix-wq-in-remote branch from c9ac652 to f72e3a7 Compare August 29, 2019 04:16
This changes the :w behavior to write in background to unfreeze the VS Code UI when the user is using VS Code Remote while allowing operation like wq and wa to work in VS Code
@stevenguh stevenguh force-pushed the feature/fix-wq-in-remote branch from f72e3a7 to 4013234 Compare August 29, 2019 04:18
@J-Fields
Copy link
Member

@suo If you get a chance, could you verify that this fixes the issue you mentioned in #3998 (comment)

@J-Fields
Copy link
Member

:wa probably doesn't need to block either, but I see that's implemented separately

@J-Fields J-Fields merged commit fef90ed into VSCodeVim:master Aug 30, 2019
@stevenguh stevenguh deleted the feature/fix-wq-in-remote branch August 30, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants