-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smile command #4070
Smile command #4070
Conversation
I realized after reading the Travis report I didn't add any tests for this, let me know if it's wanted and I can throw it into |
src/cmd_line/commands/smile.ts
Outdated
await TextEditor.insert(this.getSmileText()); | ||
} | ||
|
||
getSmileText(): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this static readonly
instead of a function
Interesting, I had no idea vim had such a command. Yes, please add tests! |
Let us know when the PR is ready for review again. |
Running Windows 10 x64 Getting a test suite failure on any suite that implements It mentions further logging available at Looks like any suite that just tests raw code functionality works correctly (via Edit: I edited the Dockerfile to remove the entrypoint so that I could start the container without it dying automatically. Here is an example log that occurs within the container when you try to run Edit2: Here's the output when manually running the test script from within the node environment inside the container where it errors when trying to spawn the child process: https://gist.github.com/caleywoods/840dfcee6d859218044c519edeb79247 -- Upon checking the directory |
Update: I have the docker test suite running. The fix from my above comment is to delete
|
@jpoon This is again ready for review. Sorry for the delay, I ventured down a test related rabbit hole because of Windows. |
Thanks! |
What this PR does / why we need it:
The VSCode Vim emulator does not replicate the
:smile
command from vim 8+; this simple addition and PR rectifies that. It's not mentioned on the roadmap but I had three reasons for this:To use this command, with a file open in the editor, simply enter
:smile
and you should be greeted with a new untitled file which contains the ascii smile text seen when you enter the:smile
command inside of vim.Special notes for your reviewer:
Thank you for having things well structured and a descriptive contribution document. This may be unwanted or unneeded, if that's the case feel free to toss it aside, it was just an exercise in doing something I wanted to do.