-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command line mode refactoring #5
Conversation
@guillermooo would you mind squashing your commits? |
sure |
@jpoon I still have a bunch of default headers and tabs in the files. I can try cleaning that up and squashing again. Or do it later. |
I'm a neat freak so I setup gulp+tslint on a private branch and we have a bunch of errors :(. Didn't bother with fixing them as (1) there were a lot and (2) Connect() is coming up fast. We can start taking care of the engineering debt when we have some basic stuff working? |
I'm learning TS as I go, so you better wait some more. :) So 👍 to paying debt off later. When we look into that, we should setup CI integration with Travis and Appveyor to run the test suite. I suppose we can output the test results to a file somehow. I will try to fix the basic stuff such as whitespace now, though. |
Well, I took a look at tslint issues and actually fixed them already. |
👍 Feel free to merge. I believe you should have that green button enabled. |
command line mode refactoring
Refactoring for simpler code. (I hope.)