Fix Bug #613 in command line writequit #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this will work. Can you also add tests? |
|
@Platzer I'm seeing 11 commits in this PR but I suppose most of them are not related to this change? |
|
Only two (4f000ad, b5e4dca) are relevant, the others must be from fork syncing. It's my second PR ever so whats the way to avoid these commits? |
|
I'm going to create a new PR to get rid of the "sync commits". I will try to add tests too. |
|
@Platzer as you're doing this on your fork, you can do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple Bug fix for #613 ":wq command does not work"