clear history when content from disk is changed #703
Conversation
| vscode.workspace.onDidChangeTextDocument((event) => { | ||
| /* TODO: Remove setTimeout (https://github.com/Microsoft/vscode/issues/11339) */ | ||
| setTimeout(() => { | ||
| if (event.document.isDirty === false) { |
There was a problem hiding this comment.
I suppose you are typing too fast to check a boolean through === :)
| @@ -114,6 +115,19 @@ export async function activate(context: vscode.ExtensionContext) { | |||
|
|
|||
| vscode.window.onDidChangeActiveTextEditor(handleActiveEditorChange, this); | |||
|
|
|||
| vscode.workspace.onDidChangeTextDocument((event) => { | |||
| /** | |||
| * Change from vscode eidtor should set document.isDirty to true but they initially don't! | |||
|
Any reason why Update: It was a github delay |
|
Generally speaking it shouldn't! You might get yourself into trouble if you've already pushed to a remote though. |
|
I know :-) |
|
@johnfn 1 test failed related to clipboard registers which i have already fixed in implement ; and , |
| @@ -217,6 +231,13 @@ async function handleKeyEvent(key: string): Promise<void> { | |||
| }); | |||
| } | |||
|
|
|||
| function handleContentChangedFromDisk(document : vscode.TextDocument) : void { | |||
| _.filter(modeHandlerToEditorIdentity, (modeHandler) => modeHandler.fileName === document.fileName) | |||
| .forEach((modeHandler) => { | |||
There was a problem hiding this comment.
Same thing about the brackets here :)
There was a problem hiding this comment.
What about them? @jpoon
There was a problem hiding this comment.
That you can remove the brackets around (modeHandler)
There was a problem hiding this comment.
|
Travis Ci is not friendly with clipboard tests, specially in mac builds. |
|
I just restarted the build. |
|
LGTM, thanks @aminroosta! |
|
This commit is amazing, now undo is trustworthy! |
@johnfn Fix for #680 !
Let me know if you need something to change :-)