Implement inccommand
#7416
Merged
Implement inccommand
#7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new config key vim.inccommand which can take values "", "append", or "replace" - Add config keys vim.substitutionColor and vim.substitutionTextColor - Add new abstract method getDecorations to CommandLine class - Move logic for computing search highlights from updateSearchHighlights method of modeHandler to getDecorations method of SearchCommandLine - Add closed field to Pattern class to keep track of whether the pattern was input with a closing delimiter - In substitute.ts, separate argument resolution from command execution, and add new method to compute substitution decorations.
When executing an :s command with the c flag: - Highlight current match with searchMatch, other matches with searchMatchHighlight - Simulate incremental replacements by concealing confirmed substitutions with decorations Move decoration utilities to their own file
When executing an :s command with the c flag: - Highlight current match with searchMatch, other matches with searchMatchHighlight - Simulate incremental replacements by concealing confirmed substitutions with decorations Move decoration utilities to their own file
J-Fields
reviewed
Jan 26, 2022
J-Fields
reviewed
Jan 26, 2022
Co-authored-by: Jason Fields <[email protected]>
|
I'm not super familiar with github actions, but is this check working as intended? The only changes were to the README, and things seem to be going wrong when it's reformatted. |
|
My pleasure! |
|
I have been using this plugin for quite sometime, and didn't realise this feature had landed until I saw the preview when using the replace command. Just came to say thank you. 🙏 😊 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces the option
inccommand, which enables a live preview of:scommands as they are typed. It also makes some improvements to interactive substitution with thecflag.The feature is configured by setting
vim.inccommandto'append'or'replace'(or''to disable).When set to
'append', substitution previews are inserted after each highlighted match, a behavior found in some popular vim emulators like spacemacs.When set to
'replace', the substitution previews replace each match, which is consistent with the default behavior of neovim.The config keys
vim.substitutionColorandvim.substitutionTextColorare provided to control the appearance of preview text.Which issue(s) this PR fixes
#6656
Also addresses #6655
Special notes for your reviewer:
Probably the biggest change from the original neovim behavior is how multi-line substitutions are handled. Since decorations can't change the apparent number of lines in the editor, concealed multi-line matches still have line breaks that won't be present once the substitution is performed. Multi-line replacements also have to be displayed inline; I currently do this by replacing line breaks with the character
⏎(U+23CE, "RETURN SYMBOL"), but it might be more sensible to use standard escape sequences.