Set high threshold and set low thershold #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymYashchenko
force-pushed
the
set_high_threshold
branch
from
f9b38c9 to
f92459b
Compare
…al.py Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
thermal.py Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
akokhan
reviewed
Feb 9, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 9, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 9, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Show resolved
Hide resolved
Signed-off-by: Vadym Yashchenko <[email protected]>
…eshold Signed-off-by: Vadym Yashchenko <[email protected]>
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Outdated
Show resolved
Hide resolved
akokhan
reviewed
Feb 14, 2022
| return float(temp) | ||
|
|
||
| def get_position_in_parent(self): | ||
| return self.__index | ||
|
|
||
| def set_high_threshold(self, temperature): | ||
| if self.check_in_range(temperature): |
There was a problem hiding this comment.
Looks like TCs supports an option to skip this (set_high_threshold API usage)
https://github.com/Azure/sonic-mgmt/blob/a4cf0c3b1810c07001e0874c91be82af1bf6f47c/tests/platform_tests/api/test_thermal.py#L306
Same for set_low_threshold...
There was a problem hiding this comment.
This is not problem of test passing. All tests was passed. This fix need only for wrong message of thermal daemon:
"Sensor tmp75-i2c-3-4c:tofino-temp temperature more then 0.5 !!!"
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Show resolved
Hide resolved
akokhan
reviewed
Feb 14, 2022
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/thermal.py
Show resolved
Hide resolved
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
VadymYashchenko
added a commit
that referenced
this pull request
Mar 8, 2022
* Signed-off-by: Vadym Yashchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)