Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 新增链接和图片处理接口 #1348

Merged
merged 4 commits into from
Jan 15, 2023
Merged

feat: 新增链接和图片处理接口 #1348

merged 4 commits into from
Jan 15, 2023

Conversation

heiyehk
Copy link
Contributor

@heiyehk heiyehk commented Jan 7, 2023 •
edited
Loading

  • 改善图片预览 #1220 改善图片预览问题，增加options->preview->showImage: boolean控制是否双击预览
  • 增加options->previewImage函数获取触发的图片节点，参数img: HTMLImageElement

链接相关

  • 增加options-> link属性，options->link->open: boolean控制点击打开链接，options->link->intercept函数控制点击的链接，参数 url: string

@heiyehk
feat: 图片相关
029f1b1 
- Vanessa219#1220 改善图片预览问题，增加options->preview->showImage: boolean控制是否双击预览
- 增加options->previewImage函数获取触发的图片节点，参数img: HTMLImageElement

链接相关
- 增加options-> link属性，options->open: boolean控制点击打开链接，intercept函数控制点击的链接，参数 url: string
@heiyehk heiyehk changed the title feat: 图片相关 feat: 图片相关&链接open Jan 7, 2023
88250
88250 requested changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@88250 88250 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请避免类似这样的格式化：

image

@heiyehk
Copy link
Contributor Author

heiyehk commented Jan 7, 2023

请避免类似这样的格式化：

图像

好的，我的失误，忘记这块改动丢弃

@heiyehk
Copy link
Contributor Author

heiyehk commented Jan 7, 2023

请避免类似这样的格式化：

image

代码格式已恢复

@88250 88250 requested a review from Vanessa219 January 7, 2023 15:23
@Vanessa219
Copy link
Owner

Vanessa219 commented Jan 11, 2023 •
edited
Loading

README 里面还麻烦进行相应的修改，谢谢。

@heiyehk
Copy link
Contributor Author

heiyehk commented Jan 12, 2023

README 里面还麻烦进行相应的修改，谢谢。

已增加本次pr的readme，并对原来的options.link.intercept重新命名为options.link.trigger，该函数并不会去做拦截操作，命名优化

@Vanessa219 Vanessa219 merged commit 6da6b67 into Vanessa219:dev Jan 15, 2023
@Vanessa219 Vanessa219 changed the title feat: 图片相关&链接open feat: 新增链接和图片处理接口 Jan 15, 2023
@Vanessa219 Vanessa219 added this to the 3.9 milestone Jan 15, 2023
@Vanessa219 Vanessa219 assigned 88250 and Vanessa219 and unassigned 88250 Jan 15, 2023
Vanessa219 added a commit that referenced this pull request Jan 15, 2023
@Vanessa219
:refactor: #1348
4ccd6fc
Vanessa219 added a commit that referenced this pull request Jan 15, 2023
@Vanessa219
:refactor: #1348
8f3bb5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@88250 88250 88250 approved these changes

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@Vanessa219 Vanessa219

@heiyehk heiyehk

Labels
引入特性
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@heiyehk @Vanessa219 @88250