Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 改进 Counter #291

Merged
merged 2 commits into from
Apr 9, 2020
Merged

🎨 改进 Counter #291

merged 2 commits into from
Apr 9, 2020

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Apr 9, 2020 •
edited
Loading

9bdc88f：改进字数统计，去除末尾换行符（解决空内容长度显示为 1 的问题）。

API 变动：counter.render 的首个参数从接收长度改为直接接收字符串。

3356608：添加 label，使字数统计意义更明确，不易引起混淆；同时为添加其他意义（例如纯字符、HTML）的长度统计打基础。

API 变动：counter.render 可选的第三个参数接收 counter 的 label，默认值为 "Markdown"。

@stevapple stevapple changed the title Counter 🎨 改进 Counter Apr 9, 2020
@Vanessa219 Vanessa219 merged commit 2fec413 into Vanessa219:dev Apr 9, 2020
@Vanessa219 Vanessa219 self-requested a review April 9, 2020 14:18
@Vanessa219 Vanessa219 added this to the 3.1.0 milestone Apr 9, 2020
Vanessa219 added a commit that referenced this pull request Apr 9, 2020
@Vanessa219
🐛 fix #291
6d7ddf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@stevapple stevapple

Labels
修复缺陷
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevapple @Vanessa219