Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持plantuml #913

Merged
merged 2 commits into from
Jan 30, 2021
Merged

支持plantuml #913

merged 2 commits into from
Jan 30, 2021

Conversation

qintang
Copy link

@qintang qintang commented Jan 30, 2021

支持plantuml,
把readme格式化还原了

@Vanessa219 Vanessa219 merged commit 814abe5 into Vanessa219:dev Jan 30, 2021
@Vanessa219 Vanessa219 changed the title Dev 支持plantuml Jan 30, 2021
@Vanessa219 Vanessa219 self-requested a review January 30, 2021 07:43
@Vanessa219 Vanessa219 added this to the 3.8 milestone Jan 30, 2021
Vanessa219 added a commit that referenced this pull request Jan 30, 2021
@Vanessa219
Copy link
Owner

谢谢,请教一下这个渲染有深色主题么?

@qintang
Copy link
Author

qintang commented Feb 1, 2021

@Vanessa219
Copy link
Owner

Vanessa219 commented Feb 1, 2021

你发的这个是 mermaid,还有我不是仁兄。。。是大姐姐

@Vanessa219
Copy link
Owner

调用多了出现这个,这个要怎么解
image

@qintang
Copy link
Author

qintang commented Feb 1, 2021

@Vanessa219 sorry,小姐姐好
我测试好多次,plantuml 服务没有出现出现你上面的情况

http://www.plantuml.com/plantuml/svg/SrJGjLDmibBmICt9oGS0

@Vanessa219
Copy link
Owner

我是把这个功能移植到思源笔记 0.7.8 里面去了。然后就会出现这个,是不是要设置什么头之类的。

@qintang
Copy link
Author

qintang commented Feb 2, 2021

image
我在思源笔记 0.7.5 采用 方式测试图片也是可以加载的
platuml server也没有同源策略。也不需要头信息。

@qintang
Copy link
Author

qintang commented Feb 2, 2021

@Vanessa219 是不是网络环境(gfw)的问题,你可以使用命令:curl http://www.plantuml.com/plantuml/svg/SrJGjLDmibBmICt9oGS0
多次测试瞧瞧

@Vanessa219
Copy link
Owner

Vanessa219 commented Feb 2, 2021

哦,我知道了,思源里面解析把 code 换成了div, innerText 没有 \n,要用 textContent。谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants