Draft: add module support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic for loading and reusing module plugins
arejula27
reviewed
Nov 17, 2023
Reworks the way recipes are loaded to allow Module plugins to make use of their own Module definitions instead of having to adjust to a central one.
|
The latest commit broke the build out of purpose, the |
Makes the resolve functions available in the api to let modules download their sources themselves
vib can now build basic recepies that do not contain nested modules!
Allows users to nest modules, making them all run as one RUN command in the containerfile
Allows users to define plugin paths manually instead of having it hardcoded to ./plugins
|
This should be ready for review and/or testing now |
Adds nested modules before the actual module as they are treated like dependencies and it does not make sense to have those after the module
creates a seperate go.mod for api/ so that plugins and vib can build using the same version of the api, instead of having vib panic every time it loads a plugin because of differing versions
|
Nice, I'll test and review during the weekend |
mirkobrombin
requested changes
Dec 3, 2023
mirkobrombin
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom module plugins to vib
current To-Do:
- [ ] port current modules to plugins (optional, may become a seperate PR)Breaking changes:
gen-modulemodule type is now completely unsupported, instead of simply being deprecated