provision phpcs + wp sniffs via composer #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfoellmann
force-pushed
the
feature/phpcs-composer
branch
2 times, most recently
from
aa793a2 to
b173300
Compare
|
(Anecdotal, but I merged this patch on my machine and it appears to also address the phpcs provisioning issue at #1179.) |
|
|
|
@thebrandonallen made the change to phpcs 2.x |
tangrufus
reviewed
May 18, 2017
provision/phpcs/composer.json
Outdated
| "type": "project", | ||
| "require": { | ||
| "oomphinc/composer-installers-extender": "^1.1", | ||
| "squizlabs/php_codesniffer": "2.*", |
There was a problem hiding this comment.
I think requiring just wp-coding-standards/wpcs is enough, as wpcs requires squizlabs/php_codesniffer with correct versions
There was a problem hiding this comment.
you are right. Fix for the PR is coming
cfoellmann
force-pushed
the
feature/phpcs-composer
branch
from
9ef72e0 to
7d72fae
Compare
cfoellmann
force-pushed
the
feature/phpcs-composer
branch
from
7d72fae to
e85e318
Compare
|
squashed everything (not best practice, i know). |
LoreleiAurora
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #922
Introduce composer installation of phpcs and the sniffs for WP and keep it in the right place.
Removes 2 git operations per provision.