install phpcs via composer #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the oversight of setting the correct path to the WP coding standards. |
|
@jeremyfelt please add |
|
Thanks @cfoellmann!
|
|
/cc @westonruter for feedback too 😄 |
| /srv/www/phpcs/scripts/phpcs --config-set installed_paths ./CodeSniffer/Standards/WordPress/ | ||
| /srv/www/phpcs/scripts/phpcs --config-set default_standard WordPress-Core | ||
| /srv/www/phpcs/scripts/phpcs -i | ||
| sudo /srv/www/phpcs/scripts/phpcs --config-set installed_paths /srv/www/phpcs-wordpress/ |
There was a problem hiding this comment.
This absolute path will break PHPCS when invoked from outside of Vagrant. This is why a relative path is used currently.
|
The path to the WPCS shouldn't be changed. |
|
@cfoellmann do you want to address the path naming and update the PR accordingly? It seems like this would help as long as we're consistent with the location. |
|
I think we need to regroup on this in a new pull request. I've opened issue #922 to describe the intent here. Thanks for the work on this @cfoellmann. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpcs needs to be installed via composer to reduce the provision process significantly. My last
vagrant provisiontook 7039 seconds! mostly due to git clones.