Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with master #192

Merged
merged 49 commits into from
Nov 17, 2023
Merged

Merge with master #192

merged 49 commits into from
Nov 17, 2023

Conversation

markos
Copy link

@markos markos commented Nov 17, 2023

Multiple changes done, namely:

markos and others added 30 commits October 3, 2023 09:57
In single.cpp featuremask with AVX512 features is not relevant to non-x86 platforms,
and just extends the runtime for no reason.
markos and others added 19 commits October 9, 2023 00:42
…n-errors

Fix clang 15,16 compilation errors on all platforms, refactor CMake build system
…untu-20.04

Ubuntu 20.04 gcc does not define HWCAP2_SVE2 #180
The use of `CMAKE_BINARY_DIR` and `CMAKE_CURRENT_BINARY_DIR` when
specifying files to set_source_files_properties caused problems
when this project is used from another CMake project.

More specifically, these variables aren't set to the expected path,
and the properties are attempted to be set for non-existant files.

This was benign before vectorscan 5.4.8 as the only properties
set were warning suppression flags.

Starting with 5.4.9, `-funsigned-char` was applied to Ragel outputs
using this method. The result is projects depending on Vectorscan
through Cmake do not have this compile flag properly applied.
Correct set_source_files_properties usage
This was causing a hard-to-track segfault with Fat Runtime on SVE2 hw,
because of the macro-based hard-coded way to calculate offsets for each
implementation. This needs a rewrite.
@markos markos merged commit 645f2ae into master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants