Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2356]: NativeTokenGateway Contract #361

Merged
merged 83 commits into from
Mar 19, 2024
Merged

[VEN-2356]: NativeTokenGateway Contract #361

merged 83 commits into from
Mar 19, 2024

Conversation

Debugger022
Copy link
Collaborator

@Debugger022 Debugger022 commented Feb 1, 2024 •
edited
Loading

Description

Resolves #[VEN-2362][VEN-2363][VEN-2364][VEN-2365]

This PR adds NativeTokenGateway contract and the following functionality in the VToken Contract:

  • borrowBehalf
  • redeemBehalf
  • redeemUnderlyingBehalf

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu mentioned this pull request Feb 6, 2024
Closed
4 tasks
GitGuru7
GitGuru7 reviewed Feb 9, 2024
View reviewed changes
contracts/Comptroller.sol Outdated Show resolved Hide resolved
contracts/Gateway/Interfaces/IVtoken.sol Outdated Show resolved Hide resolved
contracts/Gateway/Interfaces/IVtoken.sol Outdated Show resolved Hide resolved
contracts/Gateway/Interfaces/IVtoken.sol Outdated Show resolved Hide resolved
contracts/Gateway/NativeTokenGateway.sol Outdated Show resolved Hide resolved
contracts/Gateway/NativeTokenGateway.sol Outdated Show resolved Hide resolved
contracts/Gateway/NativeTokenGateway.sol Outdated Show resolved Hide resolved
contracts/Gateway/NativeTokenGateway.sol Outdated Show resolved Hide resolved
@chechu chechu added this to the 031 milestone Feb 9, 2024
@Debugger022 Debugger022 requested a review from GitGuru7 February 12, 2024 10:24
@Debugger022 Debugger022 requested a review from chechu February 19, 2024 05:29
chechu
chechu previously approved these changes Mar 11, 2024
View reviewed changes
@therealemjy therealemjy mentioned this pull request Mar 15, 2024
Merged
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 79% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 68% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 89% 61% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 96% (1559 / 1625) 75% (493 / 658) ✔

@Debugger022 Debugger022 requested a review from chechu March 18, 2024 14:54
@Debugger022 Debugger022 merged commit 493122e into develop Mar 19, 2024
4 checks passed
@chechu chechu mentioned this pull request Mar 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGuru7 GitGuru7 GitGuru7 left review comments

@0xlucian 0xlucian 0xlucian left review comments

@kkirka kkirka kkirka left review comments

@chechu chechu chechu approved these changes

@web3rover web3rover web3rover left review comments

Assignees

@Debugger022 Debugger022

Labels
audit
Projects
None yet
Milestone
031
Development

Successfully merging this pull request may close these issues.
6 participants
@Debugger022 @chechu @web3rover @kkirka @0xlucian @GitGuru7