refactor: use address from npm packages #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
approved these changes
Sep 6, 2023
coreyar
force-pushed
the
use-packages-for-addresses
branch
7 times, most recently
from
f2455ac to
21d5ec0
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
from
21d5ec0 to
20ae3d5
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
4 times, most recently
from
54461ce to
f7ffe72
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
12 times, most recently
from
6d3a573 to
d68e29a
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
5 times, most recently
from
3cd934c to
8658645
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
2 times, most recently
from
f0bcec3 to
1344d76
Compare
coreyar
force-pushed
the
use-packages-for-addresses
branch
from
1344d76 to
bd0ddf2
Compare
Comment on lines
+21
to
+25
| rm -rf contracts/protocol-reserve/contracts/Test | ||
|
|
||
| mkdir -p ./contracts/governance/contracts/Governance | ||
| mkdir -p ./contracts/governance/contracts/legacy | ||
| mkdir -p ./contracts/governance/contracts/test |
There was a problem hiding this comment.
Double checking if these Test contracts are something you want to keep
There was a problem hiding this comment.
Yes, we need this because the regular timelock delays are too long. This allows us to customize them
gleiser-oliveira
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors creating configuration files to use addresses from released packages