Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some obsoletes #749

Merged
merged 2 commits into from
Dec 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/Verify/Counter_Object.cs

This file was deleted.

11 changes: 0 additions & 11 deletions src/Verify/DerivePaths/Obsolete.cs

This file was deleted.

19 changes: 0 additions & 19 deletions src/Verify/SettingsTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,6 @@ public SettingsTask AddExtraSettings(Action<JsonSerializerSettings> action)
return this;
}

[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
public bool TryGetExtension([NotNullWhen(true)] out string? extension) =>
throw new();

/// <summary>
/// Append a key-value pair to the serialized target.
/// </summary>
Expand Down Expand Up @@ -301,16 +292,6 @@ public SettingsTask UseTextForParameters(string parametersText)
return this;
}


[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
public SettingsTask UseExtension(string extension) =>
throw new();

public VerifySettings CurrentSettings => settings ??= new();

public Task<VerifyResult> ToTask() =>
Expand Down
36 changes: 0 additions & 36 deletions src/Verify/VerifySettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -81,42 +81,6 @@ public void UseTextForParameters(string parametersText)
this.parametersText = parametersText;
}

[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
public void UseExtension(string extension) =>
throw new();

[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
public bool TryGetExtension([NotNullWhen(true)] out string? extension) =>
throw new();

[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
internal string ExtensionOrTxt(string defaultValue = "txt") =>
throw new();

[Obsolete(@"An explicit `extension` parameter has been added to all
overloads that require it:
* Verify(Stream stream, string extension)
* Verify(byte[] bytes, string extension)
* Verify(string target, string extension)
", true)]
internal string ExtensionOrBin() =>
throw new();

internal bool IsAutoVerify =>
VerifierSettings.autoVerify ||
autoVerify;
Expand Down