Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition changes to enable Verify.Cli app #888

Merged
merged 1 commit into from
May 27, 2023
Merged

Addition changes to enable Verify.Cli app #888

merged 1 commit into from
May 27, 2023

Conversation

flcdrg
Copy link
Contributor

@flcdrg flcdrg commented May 21, 2023

  • Add simple constructor to InnerVerifier for just comparing files
  • Ensure replacements field is valid even if we haven't called UseAssembly

Assists with #716

@flcdrg
Copy link
Contributor Author

flcdrg commented May 21, 2023

Coming back to this, as https://github.com/flcdrg/Verify.Cli/ is just wanting to compare a file, it doesn't have the extra type stuff that the existing constructor requires (and trying to fake it gets messy).

This change, or something like it should enable file verification by being able to reference to the Verify nupkg

@flcdrg flcdrg force-pushed the cli branch 2 times, most recently from 85ab34e to 6ca5938 Compare May 22, 2023 00:10
@flcdrg
Copy link
Contributor Author

flcdrg commented May 22, 2023

Hmm.. that change to ApplyScrubbers is breaking tests. I've got something wrong there.

@flcdrg flcdrg force-pushed the cli branch 2 times, most recently from 44f6058 to 1696076 Compare May 22, 2023 11:14
@flcdrg
Copy link
Contributor Author

flcdrg commented May 22, 2023

I think this is ready to review. Mac build had some kind of hiccup and needs to be re-queued.

@flcdrg flcdrg force-pushed the cli branch 2 times, most recently from 9b8ad0d to 7ab3f40 Compare May 25, 2023 12:13
@flcdrg
Copy link
Contributor Author

flcdrg commented May 25, 2023

Test is failing.. trying to figure out why. I can't help but notice that there's two dots in the deleted output - that seems suspicious.

VerifyException: Directory: C:\dev\git\Verify\src\Verify.Tests

VerifyException
Directory: C:\dev\git\Verify\src\Verify.Tests
Delete:
  - sample.verified..txt
Equal:
  - Received: sample.txt
    Verified: sample.verified.txt

@SimonCropp
Copy link
Member

https://github.com/VerifyTests/Verify/pull/888/files#r1205478076

@flcdrg
Addition changes to enable Verify.Cli app
f7d6a2e 
- Add simple constructor to InnerVerifier for just comparing files
- Ensure replacements field is valid even if we haven't called UseAssembly
@SimonCropp SimonCropp added this to the 20.2.0 milestone May 27, 2023
@SimonCropp SimonCropp merged commit 45a060f into VerifyTests:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCropp SimonCropp SimonCropp left review comments

Assignees
No one assigned
Labels
Feature
Milestone
20.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@flcdrg @SimonCropp