Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support mounting dynamic routes #350

Merged
merged 13 commits into from
Oct 14, 2022
Merged

fix: support mounting dynamic routes #350

merged 13 commits into from
Oct 14, 2022

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Sep 29, 2022 •
edited
Loading

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working as expected label Sep 29, 2022
@felangel felangel self-assigned this Sep 29, 2022
@felangel felangel marked this pull request as ready for review October 13, 2022 20:40
renancaraujo
renancaraujo approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lvgtm

@felangel felangel merged commit 28d72db into main Oct 14, 2022
@felangel felangel deleted the fix/mounting-dynamic-routes branch October 14, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo left review comments

@wolfenrain wolfenrain wolfenrain approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees

@felangel felangel

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: middlewares wont work with dynamic routes
4 participants
@felangel @erickzanardo @renancaraujo @wolfenrain