Tree: represent nodes as tagged unions with a packed representation #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehaas do you think the Iterator will be necessary with these changes? |
|
I haven't had nearly as much time to work on things as I'd like, so I haven't even really started using the Tree iterator yet. So if you want to remove it I say go for it and we can reassess later if it's needed. |
Vexu
force-pushed
the
rewrite-ast
branch
2 times, most recently
from
e614345 to
3661e1e
Compare
Vexu
added a commit
that referenced
this pull request
Dec 29, 2024
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Working with the current AST is annoying and difficult with similar constructs having multiple representations and dealing with multiarray list access and `@intFromEnum` and different data being stored in different data structures. The goal of this branch is to simplify the usage by having a tagged union containing all the information of that node.
Hopefully it won't be necessary with the new AST.
This change is massive enough as is.
Calls to implicitly declared functions can add to that list making it invalid for storing the previous item tokens. param_buf should be safe for this.
Vexu
added a commit
that referenced
this pull request
Dec 31, 2024
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Vexu
added a commit
that referenced
this pull request
Jan 1, 2025
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Vexu
added a commit
that referenced
this pull request
Jan 1, 2025
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Vexu
added a commit
that referenced
this pull request
Jan 2, 2025
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with the current AST is annoying and difficult with similar constructs having multiple representations and dealing with multiarray list access and
@intFromEnumand different data being stored in different data structures.The goal of this branch is to simplify the usage by having a tagged union containing all the information of that node.