-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-3949: Vector not releasing deleted file handles #154
LOG-3949: Vector not releasing deleted file handles #154
Conversation
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3cfa7d7
to
63662e2
Compare
/test unit |
2 similar comments
/test unit |
/test unit |
63662e2
to
8391ec2
Compare
/assign @jcantrill |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/approve
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, syedriko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8391ec2
to
fd150a2
Compare
@jcantrill PTAL |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
@syedriko: This pull request references LOG-3949 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For the
file
andkubernetes_logs
sources, introduced a new configuration variable,rotate_wait_ms
, of type Duration, defaulting to practical infinity. Out of the box, this default effectively turns this feature off. It determines how long vector is going to keep trying to read from a log file that has been deleted (most likely due to log rotation, hence the name of the variable). Once that time span has expired, vector closes the file descriptor of the deleted file, thus allowing the OS to reclaim the storage space occupied by the file.This behavior is similar to that of Fluentd's tail plugin: https://docs.fluentd.org/input/tail#rotate_wait
There is also a new metric being introduced -
vector_file_deleted_given_up_total
, which is a counter.JIRA:
https://issues.redhat.com/browse/LOG-3949