Fix require must have a single string literal argument error in rn. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to see this fixed 2, please consider merging soon... |
|
@MaiaVictor whats the reason for this? |
|
I'm also affected by this issue. It causes React Native to throw an exception when trying to build an app that has this library as a dependency. Here is a relevant issue posted for react-native facebook/metro#65 |
chris9753
approved these changes
Aug 27, 2018
|
Fixed conflicts, let me know if there's anything else |
|
This is still affecting react-native users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error msg: bundling failed: Error: require() must have a single string literal argument