Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup func problems (such as avg_over_time) #636

Closed
davidsome opened this issue Jul 17, 2020 · 4 comments
Closed

rollup func problems (such as avg_over_time) #636

davidsome opened this issue Jul 17, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@davidsome
Copy link

Describe the bug
when i use sum(sum_over_time(credis.exceptions.count_sum)),everything is ok。

image

when i use avg(avg_over_time(credis.exceptions.count_sum)),I found something strange.

image

I found the raw data matches sum_over_time, why avg_over_time add so many none-exists datapoints ?

$ ./victoria-metrics-prod --version
victoria-metrics-v1.37.3
@valyala valyala added the question The question issue label Jul 23, 2020
valyala added a commit that referenced this issue Jul 23, 2020
…rval between raw points for `avg_over_time`

This makes `avg_over_time` behavior consistent with `sum_over_time` and `count_over_time` behaviors.

Updates #636
valyala added a commit that referenced this issue Jul 23, 2020
…rval between raw points for `avg_over_time`

This makes `avg_over_time` behavior consistent with `sum_over_time` and `count_over_time` behaviors.

Updates #636
@valyala valyala added bug Something isn't working and removed question The question issue labels Jul 23, 2020
@valyala
Copy link
Collaborator

valyala commented Jul 23, 2020

@davidsome , thanks for the bug report!

The bug should be fixed in the following commits:

Could you build VictoriaMetrics from the commit b1f6843 according to these docs and verify whether avg_over_time works as expected now?

@valyala
Copy link
Collaborator

valyala commented Jul 24, 2020

The bugfix has been included in v1.39.0. Closing the issue as fixed.

@davidsome , feel free re-opening the issue if v1.39.0 doesn't work as expected for your case.

@valyala valyala closed this as completed Jul 24, 2020
@davidsome
Copy link
Author

davidsome commented Dec 30, 2020

@valyala the newest version I found sum_over_time behaves strange,
image

when use sum_over_time, null values becomes zero. avg_over_time is ok .is this a bug?

@valyala
Copy link
Collaborator

valyala commented Apr 2, 2021

@davidsome , I cannot reproduce this issue on the latest release of VictoriaMetrics (v1.57.1) - both sum_over_time() and count_over_time() return empty values on time ranges without raw samples.

Try exporting raw samples for these time series on the selected time range via /api/v1/export and inspecting their contents - probably they contain some unusual values there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants