Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relabelConfig separator and replacement doesn't support empty values #1214

Closed
f41gh7 opened this issue Jan 13, 2025 · 1 comment
Closed

relabelConfig separator and replacement doesn't support empty values #1214

f41gh7 opened this issue Jan 13, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@f41gh7
Copy link
Collaborator

f41gh7 commented Jan 13, 2025

At RelabelConfig

operator/api/operator/v1beta1/common_scrapeparams.go

Line 134 in b38ee45

type RelabelConfig struct {

separator and replacement fields are defined as string. Go type system doesn't allow to distinguish unset and empty type default values. And pointer to type must be used instead to make it optional.
@f41gh7 f41gh7 added the bug Something isn't working label Jan 13, 2025
f41gh7 added a commit that referenced this issue Jan 13, 2025
@f41gh7
api/relabelConfig: allow empty values for replacement and separator
a0883be 
Empty values for `replacement` and `separator` fields have special meaning. And it should optional
pointer to string.
 The same logic exists at `vmagent` side and operator must use it as well.

Related issue:
#1214

Signed-off-by: f41gh7 <[email protected]>
@f41gh7 f41gh7 added the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 13, 2025
@f41gh7
Copy link
Collaborator Author

f41gh7 commented Jan 22, 2025

Issue was fixed at v0.52.0 release

@f41gh7 f41gh7 closed this as completed Jan 22, 2025
@f41gh7 f41gh7 removed the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@f41gh7