Зотов Алексей #38
Open
Зотов Алексей #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wd055
reviewed
Oct 23, 2021
.gitignore
Outdated
| @@ -2,3 +2,4 @@ node_modules | |||
| cache | |||
| .DS_Store | |||
| .idea | |||
There was a problem hiding this comment.
Совет. Это должно быть в глобально gitignore твоей системе, а не в проекте
https://www.youtube.com/watch?v=D97rnxDqq1I
There was a problem hiding this comment.
Интересно, спасибо, настроил
pages/login.js
Outdated
| } | ||
|
|
||
| fillLoginInput(username) { | ||
| const loginLocator = this.locators.login; |
There was a problem hiding this comment.
Не уверен, как лучше. Насколько стоит выносить этот локатор в отдельную константу?
There was a problem hiding this comment.
Тоже думал об этом, убрал константу
wd055
approved these changes
Oct 23, 2021
SergTyapkin
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Написаны E2E тесты cinemedia.ru:
Отметка о прохождении тестов в allure_report.png