Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / move user routes to app routes #201

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ChristiaanScheermeijer
Copy link
Member

Description

Proposal refactor for the user/account screen. This allows for easier customisation and (imo) cleaner routing.

Copy link

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! I don't see any flaws, so approved!

Copy link

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much cleaner. Propose to OSS, or private first?

Comment on lines +184 to +185
className: userStyles.panel,
panelHeaderClassName: userStyles.panelHeader,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably take away this class forwarding as well.

@ChristiaanScheermeijer ChristiaanScheermeijer force-pushed the refactor/move-user-routes-to-app-routes branch from e7ef3db to dc21b2a Compare January 30, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants