Refactor: move account modals to separate file #202
+144
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
reviewed
Jan 8, 2025
|
|
||
| return ( | ||
| <Dialog size={dialogSize} open={!!viewParam} onClose={closeHandler}> | ||
| {shouldShowBanner && banner && ( | ||
| {!shouldShowBanner && banner && ( |
There was a problem hiding this comment.
Why is this shouldShowBanner condition reversed?
|
Looks promising. I have one inline question. Tests are failing, but your PR is still in draft |
royschut
reviewed
Jan 30, 2025
| <div className={styles.banner}> | ||
| <img src={banner} alt="" /> | ||
| </div> | ||
| )} | ||
| {renderForm()} | ||
| <Suspense fallback={fallback}>{renderForm()}</Suspense> |
There was a problem hiding this comment.
Minor: we don't need a function anymore. Maybe just a boolean for the !user etc fallback, or render currentModal.component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal refactor for the account modals. When separating the modals definition and modal component, it becomes easier to change/remove/add certain account modals.
This also applies lazy loading which means that the modals only are loaded when when rendered.