Fix: refresh entitlements on tvod purchase #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing, we found that the player never updated automatically after purchasing a TVOD item. This causes the user to be unable to play back the purchased content.
After a lot of testing and trying out different fixes, I created a temporary fix using a callback argument.
The problem
To eliminate the react dependency, we've migrated react-query to @tanstack/query-core in the common package. This didn't seem to have an impact on the app. However, it turns out that the queryClient from the common package was never being used. Instead, a different queryClient was instantiated in the ui-react package.
React Query upgrade
The most straightforward fix was to upgrade react-query to @tanstack/react-query so the new queryClient could be used. However, react-query has some breaking changes, which changed all
useQuery
statements. Specifically, when upgrading to v4, allisLoading
properties must be refactored toisFetching
orisInitialLoading
. I tried this upgrade, but it was too large and risky for now.Current fix
The AccountController only uses the
queryClient
for entitlement invalidation in 2 places. I added a temporary callback to the AccountController, which is set from theuseBootstrapApp
hook.It is not the cleanest fix, but the least risky for now.