Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / layout shift when controls are focussed on android talkback #48

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

langemike
Copy link
Contributor

We need a gap of at least 1px so the screen reader focus outline doesn't corrupt the layout when these elements get focussed. This only happens on the Android screen reader (TalkBack).

Related PR: Videodock/ott-web-app#123

Ticket: https://videodock.atlassian.net/browse/OTT-1305

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want a few pixels more?

@langemike
Copy link
Contributor Author

Don't we want a few pixels more?

Chris mentioned it. Giving it a few pixels more won't make it align with something, so I reasoned it's a little bit 'arbitrary' and subjective. However, if you think a few pixels more enhances something (visually, UX-wise), I will happily perform the change. I just thought to keep it as-is based on the reason I just mentioned. 😄

@royschut
Copy link
Contributor

@ChristiaanScheermeijer Mergy?

@ChristiaanScheermeijer
Copy link
Member

Didn't we solve this in the implementation? If not, let's merge :-D

@langemike
Copy link
Contributor Author

langemike commented Jun 20, 2024

I have losen track of this one. Also I cannot merge due to a github restriction. It says:

Merging is blocked - The base branch restricts merging to authorized users. Learn more about protected branches.

@ChristiaanScheermeijer
Copy link
Member

I found it. Because we don't use this in the jwplayer/vd-ott-app repo yet, we also changed this in the TileDock component. So, lets merge this as well to prevent running into this again later.

@ChristiaanScheermeijer ChristiaanScheermeijer merged commit 37b3488 into next Jun 20, 2024
3 checks passed
@ChristiaanScheermeijer ChristiaanScheermeijer deleted the fix/talkback-focus-issue branch June 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants