Fix various issues around article list / content views #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the file image is already specified with a (default) standard size, we can remove the superfluous size constraints on it. Set vertical hugging priority to the value suggested by Xcode after removal of the constraints. Fixes issue ViennaRSS#1618 : changing the height of the article view while viewing an article without enclosure made the enclosure view to not appear anymore whenever it should.
Position the OverlayStatusBar at bottom of Unified display view
- As the problem of instable widths (for article list or article view) are reported only with feeds having "Use Web Page for Articles" set, reverse approach of commit c491522 and enforce a constraint while the web page used as article view is loading - Simplify the NSSplitView delegates as we don't need anymore to track imbricated calls to delegates as we had to do when dealing with legacy WebViews - use the same delegate (ArticleListView) for the main NSSplitView and ArticleListView's splitView2 Solves wild resizing of window with "Use Web Page for Articles" mode on horizontal layout with feeds like https://feeds.feedburner.com/LegalInsurrection (reported in issue ViennaRSS#1722) while preserving functionality of the main split view.
Some wild resizes could still appear, with the following sequence: - see https://feeds.feedburner.com/LegalInsurrection with the "Use Web Page for Articles" setting, switch back and forth between vertical and horizontal layout - switch to another folder displayed using a built-in style, switch back and forth between vertical and horizontal layout
|
I have found two auto layout issues:
There will be a blank area where the enclosure bar was.
There will be a constraint conflict and the enclosure bar won't show. |
After resizing of one of the split views, showing enclosure view while it was hidden, or hiding enclosure view while it was visible led to auto-layout issues.
I think it's fixed now. |
Eitot
approved these changes
Aug 11, 2024
|
Thanks. I tried figuring this out, but wasn't able to fix it. I am still wondering why WKWebView forces its containing views to change their size. |
It also took me some time to completely understand when and how one needs to take care of these
I can only guess that this might be linked to the WKWebView being inside a NSStackView, which introduces some flexibility. We did not encounter the problem on other tabs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #1722 and #1618