Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2504 - please check the linked issue for more details about the issue.
Instead of relying solely on
onloadedmetadata
callback, it's been recommended to useonloadeddata
instead. I supposeloadedmetadata
gets called earlier in most cases, so it still makes sense to use it to initialize player view, however I added a flag and aonloadeddata
callback to handle the case where the loadedmetadata callback is called while the element video size attributes have not been initialized (or initialized with0
value).This ensures the player aspect ratio never gets set to
NaN
and provides an alternative way to correct the default 16:9 ratio if necessary.