Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom SponsorBlock setting #2799

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Custom SponsorBlock setting #2799

merged 3 commits into from
Jun 9, 2024

Conversation

patricgruber
Copy link
Contributor

This adds a setting to change the SponsorBlock api url to the user settings menu as described in: #1520

@patricgruber
Copy link
Contributor Author

I'm think the CSP might need to be updated in main.ts . But have to check behind a https proxy later

@moisout
Copy link
Member

moisout commented Jun 7, 2024

Very cool, thanks!

@moisout
Copy link
Member

moisout commented Jun 7, 2024 •
edited
Loading

Can you add the setting to the backend too? So it gets synced with the accounts settings.
Like this: https://github.com/ViewTube/viewtube/pull/2795/files#diff-9c6207724ba0bc59515b00a1b94f45b4cc2c7553036240dfb4c62640f439dedb

@moisout
Copy link
Member

moisout commented Jun 9, 2024

I have implemented a proxy for sponsorblock, I'll merge this and combine the two. New Release coming soon!

@moisout moisout merged commit 6777f15 into ViewTube:development Jun 9, 2024
5 checks passed
@patricgruber patricgruber mentioned this pull request Jun 9, 2024
Closed
@patricgruber
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricgruber @moisout