Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: black bg for select input dropdown options #16

Closed
wants to merge 1 commit into from

Conversation

isybub
Copy link

@isybub isybub commented Dec 27, 2024

Styles "select.input option" with bg-black, which should only affect dropdowns with the <option> tag used inside.
{A9958E6B-C1AF-47CF-9F40-4A0F4D50915D}
image

I'm new to this codebase, so just poking around, I can see a handful of hardcoded color decisions in the css here, so figured it may be an acceptable option. Let me know if there's anything I've missed :)

Not so desirable, other method

Initially simply removing the bg-transparent for all input components fixed the white background for dropdowns, however you can see the flow on effect from that was making inputs have a grey background, instead of black how it is now
image
Left is with no transparent background, which has a more grey input color.
It appears to me like the issue is something to do with background-color: transparent not properly using the black color of the content behind it, when it is coming from a dropdown, unlike the input boxes, which pick it up fine.

Copy link

vercel bot commented Dec 27, 2024

@isybub is attempting to deploy a commit to the vilsol's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
go-pob ✅ Ready (Inspect) Visit Preview Dec 27, 2024 10:51am

@Vilsol
Copy link
Owner

Vilsol commented Dec 27, 2024

@isybub what OS and browser are you using?

@isybub
Copy link
Author

isybub commented Dec 27, 2024

The white background issue was occurring on chromium browsers on windows. Having a look on other browsers, webkit ones don't appear to have the same issue, however my branch is now introducing a new change, which is the delineation between the border and the new black background on webkit browsers.
For right now, I'll retract this. I've done a little more research, unless it were to be remade with a custom component, the Option element is OS-dependent, and not really made for styling via CSS.

@isybub isybub closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants