Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multimedia keys on xS60 fork #1

Closed
wants to merge 1 commit into from

Conversation

irae
Copy link

@irae irae commented Mar 29, 2016

I was trying to track down why play/pause was not working for me and I compared your fork with tmk/tmk_keyboard/master until I could find something odd. Turns out you constrained a range for apparently no particular reason.

I tried with the broader range and found out everything works perfectly for me since. I hope this helps the community.

@VinnyCordeiro
Copy link
Owner

That was probably due to an older version of tmk being used on my fork, the current master branch solved this. I already updated the code, thank you. And sorry for the delay, had to deal with Real Life Problems™.

@irae
Copy link
Author

irae commented Apr 27, 2016

Thanks!

Quick question: why didn't you pull request this keyboard files to the maid TMK project? Wouldn't thins kind of thing take care of itself over time?

@VinnyCordeiro
Copy link
Owner

hasu prefers not to merge in the main branch keyboards that he doesn't have in hand. I've made a pull request on 9 December 2015, he answered me with this message:

Nice work! Add your repository here.
https://github.com/tmk/tmk_keyboard/wiki/TMK-Based-Projects

I won't add other's project in this repository, see this issue.
tmk#173

@irae
Copy link
Author

irae commented Apr 27, 2016

Oh, wow... I see. I will take some time to read. But the situation is awkward. Maybe we can solve with git-submodules. But the fact that if I own this and one of the keyboards on the main branch I have to deal with different branches and remotes is pretty weird.

I didn't read through the thread yet, but I believe either a plugin architecture (I could use the main makefile and add your repo as a plugin somehow) or other clean solution is needed. Relying on forks to keep "up to date with master" is inefficient. I'll see if I can come up with a proposal.

Thanks for replying once again!

@irae irae deleted the fix-mm-s60x branch April 27, 2016 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants