GCC warnings fixed

VioletGiraffe · Sep 23, 2024 · 6bdcee4 · 6bdcee4
1 parent 0060fec
commit 6bdcee4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/file-commander-core/src/fileoperations/coperationperformer.cpp b/file-commander-core/src/fileoperations/coperationperformer.cpp
@@ -322,11 +322,8 @@ void COperationPerformer::copyFiles()
 	{
 		NextAction nextAction;
 		while ((nextAction = deleteItem(dir)) == naRetryOperation);
-		switch (nextAction)
-		{
-		case naAbort:
+		if (nextAction == naAbort)
 			return;
-		}
 	}
 
 	qInfo() << __FUNCTION__ << "took" << _totalTimeElapsed.elapsed() << "ms";

diff --git a/qt-app/src/panel/filelistwidget/model/cfilelistmodel.cpp b/qt-app/src/panel/filelistwidget/model/cfilelistmodel.cpp
@@ -134,7 +134,7 @@ bool CFileListModel::setData(const QModelIndex & index, const QVariant & value,
 		emit itemEdited(hash, value.toString());
 		return false;
 	}
-	
+
 	return false;
 }
 
@@ -239,7 +239,7 @@ QMimeData *CFileListModel::mimeData(const QModelIndexList & indexes) const
 
 qulonglong CFileListModel::itemHash(int row) const
 {
-	return row < _itemHashes.size() ? _itemHashes[row] : 0;
+	return row < (int)_itemHashes.size() ? _itemHashes[row] : 0;
 }
 
 qulonglong CFileListModel::itemHash(const QModelIndex & index) const

diff --git a/qt-app/src/panel/filelistwidget/model/cfilelistmodel.h b/qt-app/src/panel/filelistwidget/model/cfilelistmodel.h
@@ -36,7 +36,7 @@ class CFileListModel final : public QAbstractItemModel
 // Drag and drop
 	[[nodiscard]] bool canDropMimeData(const QMimeData * data, Qt::DropAction action, int row, int column, const QModelIndex & parent) const override;
 	[[nodiscard]] QStringList mimeTypes() const override;
-	[[nodiscard]] bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override;
+	bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override;
 	[[nodiscard]] QMimeData* mimeData(const QModelIndexList &indexes) const override;
 
 	[[nodiscard]] qulonglong itemHash(int row) const;