Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/484 - Compound Queries as parameters in URL #1157

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

jrmartin
Copy link
Contributor

@jrmartin jrmartin commented Jul 9, 2021

Tested with query : q=VFB_00000001,SimilarMorphologyTo;%20VFBexp_FBal0276838,epFrag

Full URL http://localhost:8081/org.geppetto.frontend/geppetto?id=VFB_00017894&q=VFB_00000001,SimilarMorphologyTo;%20VFBexp_FBal0276838,epFrag

@jrmartin jrmartin requested a review from ddelpiano July 9, 2021 17:53
@jrmartin jrmartin linked an issue Jul 21, 2021 that may be closed by this pull request
@ddelpiano ddelpiano marked this pull request as ready for review July 28, 2021 11:26
Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. I used the url http://localhost:8081/org.geppetto.frontend/geppetto?id=VFB_00017894&q=VFB_00000001,SimilarMorphologyTo;%20VFBexp_FBal0276838,epFrag with my local env and I got the following

screenshot (7)

  1. Would it be possible to directly show the results rather than the let the user load them from this view?
    This will make the feature behaviour when we run single and compound queries.
    screenshot (8)

@ddelpiano ddelpiano self-requested a review August 2, 2021 13:56
@ddelpiano ddelpiano merged commit ede567c into development Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querybuilder URL trigger to take into account compound queries
2 participants