Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#531 Fix shift key bug getting stuck #1160

Merged
merged 3 commits into from
Aug 2, 2021
Merged

#531 Fix shift key bug getting stuck #1160

merged 3 commits into from
Aug 2, 2021

Conversation

jrmartin
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

@jrmartin jrmartin requested a review from ddelpiano July 15, 2021 22:28
@jrmartin jrmartin marked this pull request as draft July 15, 2021 23:50
@jrmartin jrmartin linked an issue Jul 21, 2021 that may be closed by this pull request
Geppetto isKeypressed sticking when keyup event is 'off page'. #531
Closed
ddelpiano
ddelpiano requested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrmartin I can still see the issue, am I missing anything to be merged done on the geppetto side? Thx

@ddelpiano ddelpiano marked this pull request as ready for review July 28, 2021 11:29
@jrmartin
Copy link
Contributor Author

@ddelpiano I tested this in firefox an crhome, the bug is gone in my linux machine.

@Robbie1977 Robbie1977 merged commit 34c4f37 into development Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelpiano ddelpiano ddelpiano requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geppetto isKeypressed sticking when keyup event is 'off page'.
3 participants
@jrmartin @ddelpiano @Robbie1977