Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1161 - Fix bugs with query parser in circuit browser #1167

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Feature/1161 - Fix bugs with query parser in circuit browser #1167

merged 1 commit into from
Jul 28, 2021

Conversation

jrmartin
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

@jrmartin jrmartin linked an issue Jul 21, 2021 that may be closed by this pull request
direction of paths not following given forward path. #1161
Closed
@jrmartin jrmartin requested a review from ddelpiano July 21, 2021 18:51
@jrmartin jrmartin marked this pull request as draft July 21, 2021 18:51
@ddelpiano ddelpiano marked this pull request as ready for review July 28, 2021 11:20
@ddelpiano
Copy link
Contributor

lgtm

@ddelpiano ddelpiano merged commit c9afe0b into development Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbie1977 Robbie1977 Robbie1977 approved these changes

@ddelpiano ddelpiano Awaiting requested review from ddelpiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

direction of paths not following given forward path.
3 participants
@jrmartin @ddelpiano @Robbie1977