Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the .NET Standard support from the VTS library #76

Closed
lmalenfant opened this issue Jul 29, 2023 · 0 comments · Fixed by #77
Closed

Remove the .NET Standard support from the VTS library #76

lmalenfant opened this issue Jul 29, 2023 · 0 comments · Fixed by #77
Assignees
@lmalenfant

Comments

@lmalenfant
Copy link
Member

lmalenfant commented Jul 29, 2023 •
edited
Loading

We would like to remove the support for .NET Standard 2.0 as it is no longer required for the MATLAB interoperability or the WPF application. The WPF application is now on a Windows version of .NET 6.0.

This will improve the running of unit tests, currently because we target .NET Standard and .NET 6.0 we have unit tests targeting .NET Framework 4.8 and .NET 6.0 so there are twice as many unit tests then we need.

This change will also allow us to move forward with the C# version we are using and we will be able to modernize our code to C# version 10.
@lmalenfant lmalenfant self-assigned this Jul 29, 2023
@lmalenfant lmalenfant linked a pull request Jul 29, 2023 that will close this issue
Changed the targeting to .NET 6.0 closes #76 #77
Merged
lmalenfant pushed a commit that referenced this issue Jul 31, 2023
Merge pull request #77 from VirtualPhotonics/feature/76-remove-the-ne…
07518f2 
…t-standard-support-from-the-vts-library

Changed the targeting to .NET 6.0 closes #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmalenfant lmalenfant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed the targeting to .NET 6.0 closes #76 VirtualPhotonics/VTS
1 participant
@lmalenfant