Publish / publish setup tweaks #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
alexarchambault
force-pushed
the
publish-tweaks
branch
4 times, most recently
from
adbcab8 to
88cb65a
Compare
alexarchambault
force-pushed
the
publish-tweaks
branch
2 times, most recently
from
4ff058a to
2d8399b
Compare
alexarchambault
force-pushed
the
publish-tweaks
branch
from
2d8399b to
7132b93
Compare
alexarchambault
force-pushed
the
publish-tweaks
branch
from
7132b93 to
a177379
Compare
alexarchambault
force-pushed
the
publish-tweaks
branch
from
a177379 to
b1b5c03
Compare
alexarchambault
force-pushed
the
publish-tweaks
branch
2 times, most recently
from
7ac7bed to
9f15e05
Compare
|
About this PR: I've been wanting to write non regression tests for it, but I don't recall exactly which scenarios it's fixing. But from what I recall, it's definitely useful, and the publish command should have been written this way initially IMO. And as it doesn't break any existing test, my opinion is that it can be merged as is… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I tweaked / fixed for the demo of my Scalacon talk.