-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runner specification #1445
Runner specification #1445
Conversation
modules/cli-options/src/main/scala/scala/cli/commands/SpecificationLevel.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/RestrictedCommandsParser.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented on some nitpicks and language, overall looks good
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Show resolved
Hide resolved
modules/cli-options/src/main/scala/scala/cli/commands/SpecificationLevel.scala
Outdated
Show resolved
Hide resolved
modules/cli-options/src/main/scala/scala/cli/commands/SpecificationLevel.scala
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
modules/generate-reference-doc/src/main/scala/scala/cli/doc/GenerateReferenceDoc.scala
Outdated
Show resolved
Hide resolved
2fbaaf1
to
1537864
Compare
Do we need to merge the PR or was it upstreamed somewhere for the SiP committee ? |
ac32415
to
2d216de
Compare
fixes #1419 |
680dcfc
to
c7c131f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SnippetOptions
lack the @Tag
annotation on --execute-markdown
and --markdown-snippet
options (can't comment on those lines as they're out of scope).
Otherwise, LGTM
c7c131f
to
5aa5c5f
Compare
Co-authored-by: Piotr Chabelski <[email protected]>
5aa5c5f
to
1375a36
Compare
1375a36
to
5bebf3e
Compare
Should be squash-and-merged, right? |
yes |
This commit tags commands, options and directives as
MUST have
,SHOULD have
,IMPLEMENTATION details
,Scala CLI specific
andEXPERIMENTAL
.Added a new document describing the scope of proposed Scala Runner for our SIP.