Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate scalacOptions in Mill project #1562

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Generate scalacOptions in Mill project #1562

merged 3 commits into from
Nov 15, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Nov 9, 2022

No description provided.

@lolgab lolgab force-pushed the scalacOptions-mill branch from c38ef90 to 8a586dd Compare November 9, 2022 22:17
@lolgab lolgab marked this pull request as ready for review November 9, 2022 22:38
@lolgab lolgab force-pushed the scalacOptions-mill branch from 8a586dd to ad27acd Compare November 10, 2022 07:55
@Gedochao Gedochao added the enhancement New feature or request label Nov 10, 2022
@Gedochao
Copy link
Contributor

Hey, thanks for the contribution!
Can you also add some anti-regression tests for this?

scala-cli/modules/integration/src/test/scala/scala/cli/integration/ExportMillTestDefinitions.scala

Line 9 in f470e88

abstract class ExportMillTestDefinitions(val scalaVersionOpt: Option[String])

@lolgab lolgab force-pushed the scalacOptions-mill branch from ad27acd to 2ccaa24 Compare November 10, 2022 14:57
@lolgab
Copy link
Contributor Author

lolgab commented Nov 10, 2022

@Gedochao Can you rerun the failed test? Seems unrelated.

lwronski
lwronski approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gedochao Can you rerun the failed test? Seems unrelated.

@lolgab Thanks for your contribution - LGTM. Yeah, the failed test is unrelated to your changes. I rerun CI.

@Gedochao Gedochao merged commit 844d238 into VirtusLab:main Nov 15, 2022
@lolgab lolgab deleted the scalacOptions-mill branch November 15, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@lwronski lwronski lwronski approved these changes

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @Gedochao @lwronski