Warning for multiple files with using directives #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
f6754da to
3177b49
Compare
lwronski
reviewed
Nov 17, 2022
wleczny
force-pushed
the
multiple-using-directives-handling
branch
2 times, most recently
from
929992a to
ab57955
Compare
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
ab57955 to
5f8555a
Compare
Gedochao
reviewed
Nov 18, 2022
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
5f8555a to
e1adeb8
Compare
Gedochao
approved these changes
Nov 18, 2022
romanowski
requested changes
Nov 18, 2022
wleczny
force-pushed
the
multiple-using-directives-handling
branch
3 times, most recently
from
cc565f3 to
2e43b74
Compare
wleczny
force-pushed
the
multiple-using-directives-handling
branch
3 times, most recently
from
7dd15d2 to
1db852a
Compare
wleczny
force-pushed
the
multiple-using-directives-handling
branch
3 times, most recently
from
d1a76f6 to
26c056f
Compare
romanowski
requested changes
Nov 22, 2022
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
26c056f to
e0db5a4
Compare
lwronski
reviewed
Nov 25, 2022
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
e0db5a4 to
a89ae2f
Compare
wleczny
force-pushed
the
multiple-using-directives-handling
branch
2 times, most recently
from
33b22db to
416429a
Compare
romanowski
approved these changes
Nov 28, 2022
lwronski
reviewed
Nov 28, 2022
modules/build/src/main/scala/scala/build/preprocessing/ExtractedDirectives.scala
Outdated
Show resolved
Hide resolved
modules/build/src/main/scala/scala/build/preprocessing/PreprocessingUtil.scala
Show resolved
Hide resolved
lwronski
reviewed
Nov 28, 2022
modules/build/src/main/scala/scala/build/preprocessing/DataPreprocessor.scala
Outdated
Show resolved
Hide resolved
wleczny
force-pushed
the
multiple-using-directives-handling
branch
2 times, most recently
from
8330434 to
fb4830e
Compare
wleczny
force-pushed
the
multiple-using-directives-handling
branch
from
fb4830e to
414321e
Compare
lwronski
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the requirements of #1489