Enable to force using jvm signing launcher for native launcher of scala-cli #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
signing-cli-jvm-on-native
branch
from
b8a96f4 to
6691b6e
Compare
Gedochao
reviewed
Nov 22, 2022
modules/cli/src/main/scala/scala/cli/commands/pgp/PgpScalaSigningOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/PublishOptions.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
signing-cli-jvm-on-native
branch
from
6691b6e to
66576bf
Compare
lwronski
force-pushed
the
signing-cli-jvm-on-native
branch
from
66576bf to
d5bc91c
Compare
Gedochao
approved these changes
Nov 23, 2022
lwronski
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is addressed to fix bug in CI for M1 - download error and add regression test to download JVM launcher of scala cli signing.