Add fix command #1627
Closed
Add fix command #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleczny
force-pushed
the
fix-command
branch
2 times, most recently
from
2209be9 to
ebe0936
Compare
Gedochao
force-pushed
the
fix-command
branch
from
ebe0936 to
20eae5e
Compare
Gedochao
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/fix/FixOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/fix/FixOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
|
I think this won't work with markdown inputs for now, although that can be fixed in a separate PR |
Gedochao
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Dec 15, 2022
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
lwronski
reviewed
Dec 17, 2022
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/migratedirectives/MigrateDirectives.scala
Outdated
Show resolved
Hide resolved
wleczny
force-pushed
the
fix-command
branch
2 times, most recently
from
9f89023 to
e85deed
Compare
wleczny
force-pushed
the
fix-command
branch
3 times, most recently
from
ffea39b to
7250d96
Compare
Gedochao
reviewed
Mar 17, 2023
modules/cli/src/main/scala/scala/cli/commands/fix/FixOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/fix/FixOptions.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Mar 17, 2023
modules/integration/src/test/scala/scala/cli/integration/FixTests.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Some example with directives spread between multiple files would be useful.
An example output project.scala could then be included, plus there'd be no reason to ignore the '''bash snippets in docs-tests
Gedochao
reviewed
Mar 17, 2023
lwronski
reviewed
Mar 17, 2023
|
|
||
| import com.eed3si9n.expecty.Expecty.expect | ||
|
|
||
| class FixTests extends ScalaCliSuite { |
There was a problem hiding this comment.
What happens if I now have directives in different scopes? For example main directives in Hello.scala and test directives in Hello.test.scala?
We should make sure that we don't accidentally broke someone's Scala CLI configuration.
There was a problem hiding this comment.
It should be also tested with Scala.Js and Scala native scopes.
|
Closing this, we'll make a new attempt soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.