Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account interactively picked options when caching binaries #1701

Merged

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault force-pushed the interactive-value-cache-key branch from f788d5c to 8b7969f Compare December 19, 2022 11:10
So that users can type a main class name when asked to pick a main
class.
So that tests can easily pass interactive values
@alexarchambault alexarchambault force-pushed the interactive-value-cache-key branch from 8b7969f to d596acd Compare December 19, 2022 11:21
@alexarchambault alexarchambault force-pushed the interactive-value-cache-key branch from d596acd to 268afb9 Compare December 19, 2022 11:34
@alexarchambault alexarchambault marked this pull request as ready for review December 19, 2022 13:35
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexarchambault alexarchambault merged commit 3910c24 into VirtusLab:main Dec 19, 2022
@alexarchambault alexarchambault deleted the interactive-value-cache-key branch December 19, 2022 17:29
@Gedochao Gedochao added the bug Something isn't working label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native target ignores users choice of main after the first run
3 participants