Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker packaging using directives #1753

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add docker packaging using directives #1753

merged 2 commits into from
Jan 9, 2023

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Jan 8, 2023

No description provided.

Gedochao
Gedochao approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we may want to add some more docs for it later (maybe a cookbook?)

@lwronski lwronski requested a review from Gedochao January 9, 2023 10:26
@lwronski lwronski merged commit d790aff into VirtusLab:main Jan 9, 2023
@TonioGela
Copy link

Thanks @lwronski

@Gedochao Gedochao added the enhancement New feature or request label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Awaiting requested review from Gedochao

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @TonioGela @Gedochao