Add support for running script files with no extension using shebang subcommand #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
changed the title
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
2 times, most recently
from
e4a0031 to
cf5526f
Compare
lwronski
reviewed
Jan 23, 2023
There was a problem hiding this comment.
Documentation and guide for shebang should be also updated.
modules/cli/src/main/scala/scala/cli/commands/shared/SharedOptions.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Jan 23, 2023
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
2 times, most recently
from
1879288 to
3ca43db
Compare
Gedochao
reviewed
Jan 24, 2023
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
6 times, most recently
from
0ce1a41 to
aa4eaca
Compare
Gedochao
reviewed
Jan 25, 2023
modules/build/src/main/scala/scala/build/preprocessing/SheBang.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Show resolved
Hide resolved
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
from
aa4eaca to
3aed7a6
Compare
Gedochao
approved these changes
Jan 26, 2023
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Show resolved
Hide resolved
Gedochao
reviewed
Jan 26, 2023
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Jan 26, 2023
modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala
Outdated
Show resolved
Hide resolved
julienrf
reviewed
Jan 26, 2023
There was a problem hiding this comment.
Thank you for working on this issue!
Regarding the documentation, I wonder if the “shebang” guide and the “scripts” guide should be merged? At least, I would expect the information that files with no extension are supported to be mentioned in the scripts guide.
I think it is important also to highlight better that the semantics of files with no extension is always a “script” semantics, not a “program” semantics.
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
3 times, most recently
from
3a2fdde to
17a272c
Compare
MaciejG604
force-pushed
the
shebang-run-files-without-extensions
branch
from
17a272c to
5d19c8d
Compare
Gedochao
added
enhancement
lwronski
pushed a commit
to lwronski/scala-cli
that referenced
this pull request
Feb 9, 2023
…subcommand (VirtusLab#1802) * Add support of running script files with no extension using shebang subcommand * Update documentation of shebang command and scripts
tgodzik
pushed a commit
to tgodzik/scala-cli
that referenced
this pull request
Feb 13, 2023
…subcommand (VirtusLab#1802) * Add support of running script files with no extension using shebang subcommand * Update documentation of shebang command and scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #466