blooprifle: add -XX:+IgnoreUnrecognizedVMOptions to hardCodedDefaultJavaOpts

[Flowdalic]

This was (is?) an attempt to fix #1843. However, adding this line had no effect. Just like removing the XX:MaxInlineLevel line. I assume that the error in #1843 is caused by a different code path. I suspect https://github.com/scalacenter/bloop/blob/a249e0a710ce169ca05d0606778f96f44a398680/bloopgun/src/main/scala/bloop/bloopgun/util/Environment.scala#L87, where, according to the code comment, the code in scala-cli originates from.

I wonder if it is wise to hard code non-standard JVM options like it is done here and in scalacenter/bloop. As apparently #1843 demonstrates, some (most?) JVM will bail out if they are invoked with options they do not recognize (which is IMHO sensible behavior). I would be great of all TCK compatible JVMs would be supported by scala-cli (and bloop). So either do not use non-standard hard coded options, or add -XX:+IgnoreUnrecognizedVMOptions (which, according to JDK-6788376, is available since Java 6)¹.

1: A third option would be to only issue the option if it was detected the receiving JVM supports it. But that is probably not trivial to implement.

[lwronski]

The comment here indicates that this JVM option is ignored by GraalVM, but it isn't.

I found here an interesting flag in the Graal project that may address your issue.

Can you add "-Dgraal.Inline=false" around here and check if it fix your problem?

[Flowdalic]

Can you add "-Dgraal.Inline=false" around here and check if it fix your problem?

Note that I see this error with the standalone JVM launcher and not with a native image created by Graal¹. So I assume your suggestion does not apply?

1: I execute scala-cli on an armle machine and Graal has no support for 32-bit arm.

[lwronski]

@Flowdalic Thank you for working on this issue.

I would like to suggest an alternative solution. Would it be possible for you to make the option -XX:+IgnoreUnrecognizedVMOptions configurable through an environment variable instead of hardcoding it in the default JVM options?

[lwronski]

@Flowdalic Thank you for working on this issue. I would like to suggest an alternative solution. Would it be possible for you to make the option -XX:+IgnoreUnrecognizedVMOptions configurable through an environment variable instead of hardcoding it in the default JVM options?

We discussed this internally and we agree to add -XX:+IgnoreUnrecognizedVMOptions, sorry for the confusion.

It seems the following tests are failing and will need to be adjusted:

scala.cli.integration.BloopTests.invalid bloop options passed via cli cause bloop start failure

I suspect this test can be removed as invalid JVM options should not fail bloop.

BTW. let me know if you'll don't have time to fix this, I can have a look.

[Flowdalic]

Thanks. I'll look into the test.

Your suggestion to create an environment variable made me wonder if it wouldn't be sensible to be able to override the default hardcoded JVM options via an environment variable e.g., OVERRIDE_BLOOP_JVM_OPTIONS. This would allow to experiment with different JVM options without having to modify the code.

[Gedochao]

LGTM, thanks for the contribution!