Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guide for migrating from the old scala runner to Scala CLI #1900

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add a guide for migrating from the old scala runner to Scala CLI #1900

merged 1 commit into from
Mar 6, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 2, 2023

Fixes #1749

@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Mar 2, 2023
@Gedochao Gedochao force-pushed the scala-runner-migration-docs branch 2 times, most recently from 4cf42c4 to ec54ac5 Compare March 2, 2023 14:10
@Gedochao Gedochao requested a review from MaciejG604 March 2, 2023 14:10
@Gedochao Gedochao marked this pull request as ready for review March 2, 2023 14:11
@Gedochao Gedochao requested review from lwronski and tgodzik March 2, 2023 14:11
@Gedochao Gedochao added the documentation Improvements or additions to documentation label Mar 2, 2023
@Gedochao Gedochao force-pushed the scala-runner-migration-docs branch 2 times, most recently from 888f7ca to 44b6ed5 Compare March 2, 2023 14:40
lwronski
lwronski approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao force-pushed the scala-runner-migration-docs branch from 44b6ed5 to 38a4457 Compare March 6, 2023 07:45
@Gedochao Gedochao merged commit fd1e80f into VirtusLab:main Mar 6, 2023
@Gedochao Gedochao deleted the scala-runner-migration-docs branch March 6, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@MaciejG604 MaciejG604 MaciejG604 approved these changes

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to migrate from the old scala runner to the new one
3 participants
@Gedochao @lwronski @MaciejG604